Repository navigation
Conversation
Contributor
Contributor
Author
|
@brandonkelly Adding just two methods to the This does break sites that use Aliases in a way we can't easily migrate automatically or intercept using the yii2-adapter so will require extra work from developers. |
…iases # Conflicts: # composer.lock # resources/js/modules/install/components/SiteFields.vue # src/Cp/SelectOptions.php # src/Filesystem/Filesystems/Local.php # src/Http/Controllers/InstallController.php # src/Http/Controllers/Settings/SitesController.php
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
…iases # Conflicts: # CHANGELOG.md # src/Cp/Icons.php # src/Utility/Utilities/SystemReport.php # yii2-adapter/legacy/Craft.php
Contributor
Author
|
Not removing aliases, will remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes path alias support and the alias dependency from the core codebase, replacing core usages with Laravel helpers and the Path service. Moves legacy configuration, helper, Twig, plugin, Composer, and icon alias compatibility into the Yii 2 adapter, and updates affected settings copy and tests.
Breaking change
The core UI fields that explicitly advertised or suggested aliases were:
Several additional fields implicitly accepted aliases because their values passed through
Env::parse():compiledTemplatesPath,cpIconUrl,brokenImagePath, andtempAssetUploadFsThird-party settings fields also lose alias suggestions if they use
suggestAliases,cpEnvSuggestions(true, …), orgetEnvSuggestions(true, …).